[00:31] a bit more complicate than I thought and there is no way to test the case where sample are unsigned https://hastebin.com/edoqoqazun.diff [01:09] Back [01:23] https://archive.org/details/MacintoshSharewareGames [01:24] Now with custom imagemagick'd labels [01:31] phe: yea, we have to send signed data to SDL (I tried AUDIO_U16LSB but it gave me that error, above) [01:32] phe: but I think the data coming from PCE is actually unsigned [01:40] I thought the low data can be unsigned but pce machine arch driver convert if needed to signed, so the callback can get only signed samples? [01:40] *low level data [01:42] phe: the low level data is 8-bit [01:43] yes, isn't it converter so signed 16? [01:43] snd_sdl_write gets a buffer of 8-bit data, and uses snd_set_buf (shared between all drivers) to convert it to 16-bit [01:44] snd_sdl_write receive 16 bit sample, but yes, data can be unsigned [01:46] sdrv (sdl things) hardcode drv->sign = 1; so imho the callnack can only get signed 16 samples [01:47] it's done in snd_sdl_set_params [01:47] yes, possibly [01:49] the mac_sound_t has a uint16_y[370] for the sound buffer [01:49] _t [01:50] bai: Agreed, we should do https://github.com/copy/v86 [01:52] snd_write receive that uint16_t, it call sdrv->write (sdrv, sbuf, cnt); == snd_sdl_write which alloc or reuse a free buffer convert/copy then this buffer is ready for the sound thread to be used by the callback [01:53] db48x, btw do you know if the browser use a worker thread for the sound [01:53] ? [01:59] https://archive.org/details/CrystalQuest_2_2_5M [01:59] db48x and phe - sounds like another round of sound is bring done? [02:09] imho sound works as it, only minor improvement will go in [02:11] So that opening slight buzz, that's fine? [02:11] I mean, it sounds so great as is [02:11] I just don't want to bulldoze anyone into putting out work they're not comfortable with [02:38] *** phe has quit IRC (Quit: Leaving) [02:46] *** SketchCow sets mode: +oooo arkiver bai balrog db48x [02:46] *** SketchCow sets mode: +oooo devesine_ DFJustin godane jvilk [02:46] *** SketchCow sets mode: +o Lord_Nigh [03:08] Fixing it will be a slight change but it'll be good. [03:35] * SketchCow polishes blog entry a tad more [03:58] (I think db48x fell asleep) [03:58] How dare he [12:00] *** phe has joined #jsmess [15:24] http://blog.archive.org/2017/04/16/early-macintosh-emulation-comes-to-the-archive/ [15:30] let me know if I messed up [17:00] awesome, great work guys [20:19] off to heaven [20:20] lots of people visiting [20:20] no complaints [22:16] a/win 3