#jsmess 2018-09-04,Tue

↑back Search

Time Nickname Message
00:11 🔗 SketchCow OK, so
00:11 🔗 SketchCow First, congratulations, that's a huge deal.
00:19 🔗 SketchCow Second, I think it's best to just make a spreadsheet of what the patch does
00:19 🔗 SketchCow And then just consider why each choice was made
00:19 🔗 SketchCow Maybe some make no sense
00:19 🔗 SketchCow I note how he has two patches there, one for 2.4 and 2.4.4 and he actually made 2.4.4 significantly bigger
00:20 🔗 SketchCow I pinged the guy a few times trying to be able to weigh in on thinking
00:46 🔗 Sgeo_ I think something's wrong with the .patch file
00:47 🔗 Sgeo_ https://i.imgur.com/H5RTodU.png
00:47 🔗 Sgeo_ That shouldn't be the only change in that file, according to a manual reading of the .patch file
00:54 🔗 SketchCow Well, I wouldn't expect the patch file to work unmodified!
00:54 🔗 SketchCow I mean, it's been 5 years between versions here
00:54 🔗 SketchCow 2.4 to 3.2, a huge leap
01:00 🔗 Sgeo_ AFK
01:09 🔗 db48x Sgeo_: if the patch adds lines that turn out to be present in the new version, or removes lines that turn out to already be removed, then those hunks will dissapear when you go to apply the patch
01:09 🔗 db48x disappear
01:16 🔗 SketchCow I mean... it's working, right? Just blowing up on devices and interaction
01:16 🔗 SketchCow That's huge
02:21 🔗 Sgeo_ Err, did I misstate something?
02:21 🔗 Sgeo_ It's not working yet
02:22 🔗 SketchCow That error message, in vice
02:22 🔗 SketchCow That means it's working
02:23 🔗 SketchCow It just errors out because it can't interact
02:23 🔗 SketchCow Vice boots up and then does checks and fails those checks and gives the error
02:23 🔗 SketchCow Take the W Sgeo_
02:23 🔗 Sgeo_ If you insist
02:24 🔗 Sgeo_ This patch modifies a file that does not exist. It also modifies a file that does exist in the same exact way and I believe is used to make the currently non-existent file, so I'll change that
02:35 🔗 Sgeo_ The patch switches the license text used, from a 40-column one to a larger column onbe
02:37 🔗 Sgeo_ There's a file I think I attempted to patch, wasnt successful. It looks like the lines in question have already been commented out, in a different way from the VICE.js patching
02:38 🔗 Sgeo_ "remove remains of old hack, supposedly makes free scaling work again on some setups" in the real VICE code, in 2013, commented out those lines
02:51 🔗 Sgeo_ Rectangular select is so nice
02:53 🔗 Sgeo_ Not sure what this syntax in the maincpu.c part of the patch is, I might try my prior approach there first and see what happens
03:14 🔗 Sgeo_ /bin/bash: ./gentranslate: Permission denied
03:14 🔗 Sgeo_ Buh?
03:15 🔗 Sgeo_ hmm, in this version, it's LLVM IR bytecode like you reported. In the directory I was using before, it's an executable
03:19 🔗 Sgeo_ configure; make x64 made a new gentranslate. The make died afterwards, but an executable gentranslate was made
03:24 🔗 Sgeo_ wave.cc:34:10: fatal error: 'wave6581__ST.h' file not found
03:24 🔗 Sgeo_ #include "wave6581__ST.h"
03:25 🔗 Sgeo_ Ok so that's dynamically created somehow or other I believe. Not sure how
03:26 🔗 Sgeo_ Going straight for "make x64" was a mistake
03:38 🔗 Sgeo_ error: Linking globals named 'file_system_get_vdrive': symbol multiply defined!
03:39 🔗 Sgeo_ I was sort of expecting multiple console_closes, since I didn't add in my change to fix that yet
03:39 🔗 Sgeo_ Wasn't expecting file_system_get_vdrive thing
03:44 🔗 Sgeo_ emmake make clean; emmake make x64
03:47 🔗 Sgeo_ So utterly bizarre. make leaving behind essential things that make clean does not clean up
03:52 🔗 Sgeo_ I feel further away then before
03:52 🔗 Sgeo_ https://i.imgur.com/l0DAw6Z.png
03:53 🔗 Sgeo_ Although at least I learned about some nonsense hoops I didn't know about and inadvertently skipped before
03:53 🔗 Sgeo_ Going to call it a night
04:03 🔗 SketchCow Great work, thank you
04:17 🔗 Sgeo_ You're welcome
04:38 🔗 Sgeo_ Tomorrow going to try switching to SDL1. Already seeing why one change in the patch was made for that
14:49 🔗 Sgeo has joined #jsmess
14:50 🔗 Sgeo_ has quit IRC (Read error: Operation timed out)
20:46 🔗 Sgeo has quit IRC (Read error: Operation timed out)
20:55 🔗 Sgeo has joined #jsmess
21:42 🔗 Sgeo has quit IRC (Read error: Operation timed out)
22:16 🔗 Sgeo has joined #jsmess
22:20 🔗 Sgeo_ has joined #jsmess
22:23 🔗 Sgeo has quit IRC (Read error: Operation timed out)
22:48 🔗 Sgeo_ Yay I have Internet back
22:49 🔗 Sgeo_ sdlsound.c is giving me errors about undeclared functions. There are changes in the vice.js patch that affect sdlsound. I applied those changes on the SDL2 side of the config but not the SDL1 side. Obvious thing to do is try applying them
22:56 🔗 SketchCow Yep
23:03 🔗 Sgeo_ That didn't work. I could just go ahead and include this header the compiler tells me to include.
23:10 🔗 Sgeo_ Well, a whole bunch of files wanted that same header, so I took the easy way out and threw it in vice.h. Would love to know why it wasn't being included properly. (Maybe I misapplied the patch to the config?). Compiling now though
23:31 🔗 Sgeo_ _SDL_UnlockSurface@http://localhost:8000/x64.js:9106:7 is failing an assertion
23:34 🔗 Sgeo_ assert(!SDL.GL); // in GL mode we do not keep around 2D canvases and contexts
23:34 🔗 Sgeo_ bai, any ideas why Emscripten's SDL1 would assert !SDL.GL and why SDL.GL would actually be in use?

irclogger-viewer