Time |
Nickname |
Message |
00:31
🔗
|
phe |
a bit more complicate than I thought and there is no way to test the case where sample are unsigned https://hastebin.com/edoqoqazun.diff |
01:09
🔗
|
SketchCow |
Back |
01:23
🔗
|
SketchCow |
https://archive.org/details/MacintoshSharewareGames |
01:24
🔗
|
SketchCow |
Now with custom imagemagick'd labels |
01:31
🔗
|
db48x |
phe: yea, we have to send signed data to SDL (I tried AUDIO_U16LSB but it gave me that error, above) |
01:32
🔗
|
db48x |
phe: but I think the data coming from PCE is actually unsigned |
01:40
🔗
|
phe |
I thought the low data can be unsigned but pce machine arch driver convert if needed to signed, so the callback can get only signed samples? |
01:40
🔗
|
phe |
*low level data |
01:42
🔗
|
db48x |
phe: the low level data is 8-bit |
01:43
🔗
|
phe |
yes, isn't it converter so signed 16? |
01:43
🔗
|
db48x |
snd_sdl_write gets a buffer of 8-bit data, and uses snd_set_buf (shared between all drivers) to convert it to 16-bit |
01:44
🔗
|
phe |
snd_sdl_write receive 16 bit sample, but yes, data can be unsigned |
01:46
🔗
|
phe |
sdrv (sdl things) hardcode drv->sign = 1; so imho the callnack can only get signed 16 samples |
01:47
🔗
|
phe |
it's done in snd_sdl_set_params |
01:47
🔗
|
db48x |
yes, possibly |
01:49
🔗
|
db48x |
the mac_sound_t has a uint16_y[370] for the sound buffer |
01:49
🔗
|
db48x |
_t |
01:50
🔗
|
SketchCow |
bai: Agreed, we should do https://github.com/copy/v86 |
01:52
🔗
|
phe |
snd_write receive that uint16_t, it call sdrv->write (sdrv, sbuf, cnt); == snd_sdl_write which alloc or reuse a free buffer convert/copy then this buffer is ready for the sound thread to be used by the callback |
01:53
🔗
|
phe |
db48x, btw do you know if the browser use a worker thread for the sound |
01:53
🔗
|
phe |
? |
01:59
🔗
|
SketchCow |
https://archive.org/details/CrystalQuest_2_2_5M |
01:59
🔗
|
SketchCow |
db48x and phe - sounds like another round of sound is bring done? |
02:09
🔗
|
phe |
imho sound works as it, only minor improvement will go in |
02:11
🔗
|
SketchCow |
So that opening slight buzz, that's fine? |
02:11
🔗
|
SketchCow |
I mean, it sounds so great as is |
02:11
🔗
|
SketchCow |
I just don't want to bulldoze anyone into putting out work they're not comfortable with |
02:38
🔗
|
|
phe has quit IRC (Quit: Leaving) |
02:46
🔗
|
|
SketchCow sets mode: +oooo arkiver bai balrog db48x |
02:46
🔗
|
|
SketchCow sets mode: +oooo devesine_ DFJustin godane jvilk |
02:46
🔗
|
|
SketchCow sets mode: +o Lord_Nigh |
03:08
🔗
|
SketchCow |
Fixing it will be a slight change but it'll be good. |
03:35
🔗
|
* |
SketchCow polishes blog entry a tad more |
03:58
🔗
|
SketchCow |
(I think db48x fell asleep) |
03:58
🔗
|
SketchCow |
How dare he |
12:00
🔗
|
|
phe has joined #jsmess |
15:24
🔗
|
SketchCow |
http://blog.archive.org/2017/04/16/early-macintosh-emulation-comes-to-the-archive/ |
15:30
🔗
|
SketchCow |
let me know if I messed up |
17:00
🔗
|
bai |
awesome, great work guys |
20:19
🔗
|
SketchCow |
off to heaven |
20:20
🔗
|
SketchCow |
lots of people visiting |
20:20
🔗
|
SketchCow |
no complaints |
22:16
🔗
|
SketchCow |
a/win 3 |