| Time |
Nickname |
Message |
|
21:35
🔗
|
soultcer |
alard: I thought further about moving tinyback from my personal github account to the archivteam organization |
|
21:35
🔗
|
soultcer |
A possible fix would be to add a timeout for the git pull (so basically extend AsyncPOpen to support timeouts), then the pull will timeout, urlteam will be marked as failed project and removed. |
|
21:35
🔗
|
soultcer |
The git pull will then hang forever, because when a repository does not exist, github asks for username/password because it might just be a private repository. |
|
21:35
🔗
|
soultcer |
The warrior only git pulls if the repository already exists on the harddisk, which means it won't notice that the URL has changed. |
|
21:35
🔗
|
soultcer |
And then, on the next try, the warrior will just clone the whole repository from the new URL. |
|
21:36
🔗
|
soultcer |
Does that make sense? |
|
21:39
🔗
|
alard |
Wouldn't it be easier to just remove the password prompt? |
|
21:41
🔗
|
alard |
This seems to work: GIT_ASKPASS=echo git clone https://github.com/ArchiveTeam/nonexistent.git |
|
21:42
🔗
|
ersi |
or just 'echo git add remote lololol' |
|
21:43
🔗
|
alard |
What would that do? |
|
21:44
🔗
|
ersi |
I was thinking of manipulating .git/config and changing the URL of the repo |
|
21:46
🔗
|
soultcer |
git config remote.origin.url "$URL" would work too |
|
21:47
🔗
|
soultcer |
So 1) Update warrior code to always the the git remote before pull, 2) Remove urlteam project from warriorhq, 3) Ask github to switch project over to organization, 4) re-add urlteam project to warriorhq |
|
21:47
🔗
|
ersi |
to always the the |
|
21:47
🔗
|
ersi |
By the way; What's the preferred way of doing changes to our projects? Branch and submit pull request? |
|
21:47
🔗
|
alard |
Yes, and 5) add GIT_ASKPASS=echo anyway, since the asking-a-password is never a good idea. |
|
22:06
🔗
|
alard |
Something like this? https://github.com/ArchiveTeam/seesaw-kit/compare/master...development |
|
22:08
🔗
|
soultcer |
Yes, this should work. Did you try it inside a warrior? |
|
22:09
🔗
|
soultcer |
Now that I think about it, simply changing the repository URL is much better, because then the whole "failed project, reclone project" cycle is avoided |
|
22:09
🔗
|
alard |
I'm going to try. My warrior is currently busy with two large DailyBooth users. |
|
22:13
🔗
|
alard |
It works if I run the warrior scripts on my own computer, so I think it works. |
|
22:13
🔗
|
alard |
I changed the repository url before updating, the warrior changed it back. |
|
23:13
🔗
|
alard |
The new version of seesaw works, so I've added it to the production branch. We should wait a few days for the warriors to update. |
|
23:14
🔗
|
alard |
(The urlteam tracker has new colors, I see. Nice!) |
|
23:16
🔗
|
soultcer |
Google graphs are awesome :D |
|
23:18
🔗
|
soultcer |
Moving repositores needs to be authorized manually by Github staff, so we will have to remove the urlteam project, then ask github to switch accounts, and then can re-add the project, because we won't know exactly when the switch will happen |